Add fine-grained features to control the compilation #189
+135
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xynnn007
changed the title
flavio
reviewed
Jan 24, 2023
There was a problem hiding this comment.
wow, that's a monumental contribution. Thanks!
I left some minor comments, feel free to ignore the suggestion about using cfg-if.
There's however another thing I would like to see: can you update the inline documentation to explain the different features and what their purpose is? I imagine something like tokio documentation does here
Xynnn007
force-pushed
the
feat-features
branch
from
5a6a26f
to
eba6b95
Compare
Some dependencies are only used in a part of the lib. New features are brought for users to specify to reduce useless dependencies. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
To run the examples correctly, the simplest way is to enable all the features. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Xynnn007
force-pushed
the
feat-features
branch
from
eba6b95
to
a84bbdd
Compare
|
The clippy errors seem not related to this PR. Let me fix them in another PR first, although a great headache :-( |
flavio
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr tries to divide different modules (like
fulcio,rekorandcosign) into different features. The dependencies of the unenabled features will not be compiled to save space and time.Release Note
New features are introduced, including
full-native-tls,full-rustls-tls: full stackfulcio-native-tls,fulcio-rustls-tls: fulciorekor-native-tls,rekor-rustls-tls: rekorcosign-native-tls,cosign-rustls-tls: cosignmock-client-native-tls,mock-client-rustls-tls: mock client for testcached-client: whether usescached-clientoptionDocumentation
Close #187